Vouched Contributor request: Add support for custom TLDS

General
1

I found myself in the same situation as the past (now closed) issue: Invalid domain name , from two weeks ago

The accepted solution (sent by the Stalwart team) mentioned considering to add a configurable list of custom TLDs, to be considered valid, in addition to the ICANN and reserved ones

Since i found myself needing this same feature, i implemented it myself

It’s a 15 line change that would allow the user to specify a comma separated list of TLDs in an env (STALWART_CUSTOM_TLDS), to be considered valid

The PR would consist of this single commit: feat: allow usage of custom tlds · piorpiedev/stalwart@803825e · GitHub

Sorry if this isn’t the correct topic type, but it didn’t fit as an issue nor as a feature idea

Let me know if i should make any changes (for example by using a Vec instead of an AHashSet, since the list will probably be pretty small)

1 Like
2

I’m sorry but that PR is unacceptable for both code quality and design issues.

3

Fair enough, i’ll just keep using my fork until it gets implemented some other way. Thank you for keeping the project open source!